Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update project to use nodejs 20, npm >=10.5.2 #2062

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Commits on Aug 27, 2024

  1. 🌱 Update project to use nodejs 20, npm >=10.5.2

    Upgrade the project to use nodejs-20 in the `Dockerfile`,
    and package.json engine block.  More specific entries
    for `.dockerignore` will help keep the `COPY` step quick.
    
    Reasoning:
      - nodejs-18 is in LTS until May 2025, but nodejs-20 will
        be in LTS until May 2026. [^1]
    
      - node and npm are distributed together, and the
        `ubi9/nodejs-20` container has a newer version of
        npm included (10.7.0) than the current `ubi9/nodejs-18`
        container (10.5.0)
    
      - Given github issues [^2] and [^3], we can assume that
        the only versions of npm that will be stable in CI
        during the `npm install` phase are `npm@9` and `npm@>=10.5.2`.
        Any npm version <10.5.2 is at severe risk of encountering
        network errors when installing packages, especially when
        running in a qemu environment for non-native architecture
        builds.
    
      - Being very specific in the `package.json` `engines` block
        will help keep everyone on working versions of npm.
    
    [^1]: https://nodejs.org/en/about/previous-releases
    [^2]: npm/cli#7231
    [^3]: npm/cli#7072
    
    Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
    sjd78 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6ca3fa4 View commit details
    Browse the repository at this point in the history