Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Re-enable fetching applications after application import #1856

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

rszwajko
Copy link
Collaborator

@rszwajko rszwajko commented Apr 17, 2024

After successful import re-enable useFetchApplications() hook for the next 15 seconds.

Resolves: https://issues.redhat.com/browse/MTA-2451

@rszwajko rszwajko marked this pull request as ready for review April 17, 2024 18:54
@ibolton336
Copy link
Member

Works great - Thank you Radek!

Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take it or leave it: use DayJS for the date calculation.

@ibolton336 ibolton336 added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Apr 18, 2024
After successful import re-enable useFetchApplications() hook for the
next 15 seconds.

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
@ibolton336 ibolton336 self-requested a review April 19, 2024 17:54
Copy link
Member

@ibolton336 ibolton336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that if you import on the manage imports page & quickly navigate to the applications page, the bug is still there. ( maybe a separate bug).

Looks like it was an issue with my env.

@ibolton336 ibolton336 self-requested a review April 19, 2024 18:16
@sjd78 sjd78 added this to the v0.3.2 milestone Apr 19, 2024
@rszwajko rszwajko merged commit 3996cf7 into konveyor:main Apr 22, 2024
7 checks passed
rszwajko added a commit to rszwajko/tackle2-ui that referenced this pull request Apr 22, 2024
…1856)

After successful import re-enable useFetchApplications() hook for the
next 15 seconds.

Resolves: https://issues.redhat.com/browse/MTA-2451

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this pull request Apr 22, 2024
…1856)

After successful import re-enable useFetchApplications() hook for the
next 15 seconds.

Resolves: https://issues.redhat.com/browse/MTA-2451

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
rszwajko added a commit to rszwajko/tackle2-ui that referenced this pull request Apr 22, 2024
…1856)

After successful import re-enable useFetchApplications() hook for the
next 15 seconds.

Resolves: https://issues.redhat.com/browse/MTA-2451

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
sjd78 pushed a commit that referenced this pull request Apr 22, 2024
…ation import (#1876)

After successful import re-enable useFetchApplications() hook for the
next 15 seconds.
    
Resolves: https://issues.redhat.com/browse/MTA-2451
Cherry-picked from: #1856

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
kpunwatk pushed a commit to kpunwatk/tackle2-ui that referenced this pull request Apr 23, 2024
…1856)

After successful import re-enable useFetchApplications() hook for the
next 15 seconds.

Resolves: https://issues.redhat.com/browse/MTA-2451

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
kpunwatk pushed a commit to kpunwatk/tackle2-ui that referenced this pull request Apr 25, 2024
…1856)

After successful import re-enable useFetchApplications() hook for the
next 15 seconds.

Resolves: https://issues.redhat.com/browse/MTA-2451

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants