🐛 Show first non-empty line in incident message overflow tab #1841
Conversation
Signed-off-by: Ian Bolton <ibolton@redhat.com>
ibolton336
added
the
cherry-pick/release-0.3
|
|
||
| const getFirstNonEmptyLine = (message: string) => { | ||
| const lines = message.split("\n"); | ||
| return lines.find((line) => line.trim() !== "") || "No content available."; |
There was a problem hiding this comment.
IMHO the no-content label should be styled as a placeholder to clearly distinguish from the analyzed code. If not possible I would use empty string.
There was a problem hiding this comment.
Since this text is parsed as Markdown, there are some edge cases that could be a problem. If the first non-empty line is triple back-tick (like for a code block), weird things could happen.
I don't mind if there is markdown message here like _(empty message)_ or some such, but it would make more sense up in the <Td>.
|
|
||
| const getFirstNonEmptyLine = (message: string) => { | ||
| const lines = message.split("\n"); | ||
| return lines.find((line) => line.trim() !== "") || "No content available."; |
There was a problem hiding this comment.
Since this text is parsed as Markdown, there are some edge cases that could be a problem. If the first non-empty line is triple back-tick (like for a code block), weird things could happen.
I don't mind if there is markdown message here like _(empty message)_ or some such, but it would make more sense up in the <Td>.
| <ReactMarkdown components={markdownPFComponents}> | ||
| {`${incident.message.split("\n")[0]} ...`} | ||
| {`${getFirstNonEmptyLine(incident.message)} ...`} | ||
| </ReactMarkdown> |
There was a problem hiding this comment.
Maybe more like "if message is blank (i.e. only has whitespace, is empty string, or is falsey), then render a "no message" placeholder else render the ReactMarkdown component.
Then getFirstNonEmptyLine() can be assured there is a line to find!
|
Signed-off-by: Ian Bolton <ibolton@redhat.com>
| return nonEmptyLine || null; | ||
| }; | ||
|
|
||
| const messageDisplayComponent = (message: string) => { |
There was a problem hiding this comment.
| const messageDisplayComponent = (message: string) => { | |
| const MessageDisplayComponent: React.FC<{message: string}> = ({ message }) => { |
| <ReactMarkdown components={markdownPFComponents}> | ||
| {`${incident.message.split("\n")[0]} ...`} | ||
| </ReactMarkdown> | ||
| {messageDisplayComponent(incident.message)} |
There was a problem hiding this comment.
| {messageDisplayComponent(incident.message)} | |
| <MessageDisplayComponent message={incident.message} /> |
Resolves https://issues.redhat.com/browse/MTA-1959 --------- Signed-off-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
…1851) Resolves https://issues.redhat.com/browse/MTA-1959 --------- Backport-of: #1841 Signed-off-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Resolves https://issues.redhat.com/browse/MTA-1959