Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix proxies for express server / prod build #1288

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

sjd78
Copy link
Member

@sjd78 sjd78 commented Aug 15, 2023

The order request handlers are added to the express server matters much more than anticipated. This rearrangement allows POST requests etc through the proxy to work again.

The order request handlers are added to the express server matters
much more than anticipated.  This rearrangement allows POST requests
etc through the proxy to work again.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a9f64a7) 43.08% compared to head (08d859c) 43.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1288   +/-   ##
=======================================
  Coverage   43.08%   43.08%           
=======================================
  Files         143      143           
  Lines        4296     4296           
  Branches      998      998           
=======================================
  Hits         1851     1851           
  Misses       2364     2364           
  Partials       81       81           
Flag Coverage Δ
client 43.08% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibolton336 ibolton336 merged commit edf2855 into konveyor:main Aug 15, 2023
6 checks passed
@sjd78 sjd78 deleted the fix_express branch September 13, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants