Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Task Manager Drawer - scroll the list to fetch more tasks to display #1973

Closed
sjd78 opened this issue Jun 20, 2024 · 0 comments · Fixed by #2049
Closed

[BUG] Task Manager Drawer - scroll the list to fetch more tasks to display #1973

sjd78 opened this issue Jun 20, 2024 · 0 comments · Fixed by #2049
Assignees
@rszwajko
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.6.0

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 20, 2024

Followup to #1955

Note 1: Until fetch more / infinite scroll is implemented in the task manager drawer list, only the first 20 queued tasks will be displayed.

Add an infinite scroll fetch to the tack manager drawer to make it easy to load a long list of queued tasks. Alternatively, use a "...load more tasks" kind of indicator list item that requires a user to manually click to load additional tasks.
@sjd78 sjd78 added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. labels Jun 20, 2024
@sjd78 sjd78 added this to the v0.5.0 milestone Jun 20, 2024
@dymurray dymurray modified the milestones: v0.5.0, v0.5.1 Jul 18, 2024
@rszwajko rszwajko self-assigned this Aug 5, 2024
@sjd78 sjd78 modified the milestones: v0.5.1, v0.6.0 Aug 7, 2024
@rszwajko rszwajko mentioned this issue Sep 3, 2024
Merged
rszwajko added a commit that referenced this issue Sep 9, 2024
@rszwajko @sjd78
✨ Use InfiniteScroller pattern for the Task Drawer (#2049)
7cd3ebb 
Implement InfiniteScroller based on oVirt VmPortal implementation and
use it to fetch additional tasks in the Task Drawer.

Key features:
1. fetch data using useInfiniteQuery from React Query
2. track sentinel visibility using IntersectionObserver API
3. monitor item count to prevent extra fetchMore calls
4. ensure that state setter is not called on unmounted component (from 
    IntersectionObserver callback)

Resolves: #1973
Reference-Url: https://github.com/oVirt/ovirt-web-ui/blob/dfe0c4b8c92638f6e41b9fe0b09e0d07509618ae/src/components/VmsList/index.js#L50

---------

Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Co-authored-by: Scott Dickerson <sdickers@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rszwajko rszwajko

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

✨ Use InfiniteScroller pattern for the Task Drawer rszwajko/tackle2-ui
3 participants
@sjd78 @dymurray @rszwajko