Skip to content

Commit

Permalink
πŸ› Add download attribute to csv import template link (#1512)
Browse files Browse the repository at this point in the history
Solves [MTA-1592](https://issues.redhat.com/browse/MTA-1592)

@ibolton336 Could you please review this PR? Thanks!


![image](https://github.com/konveyor/tackle2-ui/assets/117646518/4c58ee01-b456-4c1b-8b93-e1fb3e31a17c)

<!--
## PR Title Prefix

Every **PR Title** should be prefixed with :text: to indicate its type.

- Breaking change: ⚠️ (`⚠️`)
- Non-breaking feature: ✨ (`✨`)
- Patch fix: πŸ› (`πŸ›`)
- Docs: πŸ“– (`πŸ“–`)
- Infra/Tests/Other: 🌱 (`🌱`)
- No release note: πŸ‘» (`πŸ‘»`)

For example, a pull request containing breaking changes might look like
`⚠️ My pull request contains breaking changes`.

Since GitHub supports emoji aliases (ie. `πŸ‘»`), there is no need to
include
the emoji directly in the PR title -- **please use the alias**. It used
to be
the case that projects using emojis for PR typing had to include the
emoji
directly because GitHub didn't render the alias. Given that `⚠️`
is
easy enough to read as text, easy to parse in release tooling, and
rendered in
GitHub well, we prefer to standardize on the alias.

For more information, please see the Konveyor
[Versioning
Doc](https://github.com/konveyor/release-tools/blob/main/VERSIONING.md).
-->

Signed-off-by: Alejandro Brugarolas <abrugaro@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
  • Loading branch information
abrugaro and ibolton336 committed Nov 2, 2023
1 parent a797572 commit 35c9cff
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,13 @@ export const ManageImports: React.FC = () => {
dropdownItems={[
<DropdownItem
key="download-csv-template"
to="/template_application_import.csv"
component={(props) => (
<a
{...props}
download
href="/template_application_import.csv"
/>
)}
>
{t("actions.downloadCsvTemplate")}
</DropdownItem>,
Expand Down

0 comments on commit 35c9cff

Please sign in to comment.