⚠️ Only trigger discovery tasks if the Application has a repository specified #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
jortel
reviewed
Jul 9, 2024
api/application.go
Outdated
| if err != nil { | ||
| _ = ctx.Error(err) | ||
| return | ||
| if r.Repository != nil { |
There was a problem hiding this comment.
How about moving the check for the repository into the trigger.Application? When the repository is nil, the trigger could no-op.
By encapsulating/delegating the check to the trigger it can be done in one place and shared by multiple callers. Further, the caller does not need to be concerned.
mansam
force-pushed
the
discovery-require-repository
branch
from
e2f8d79
to
a6a3aec
Compare
mansam
commented
Jul 10, 2024
trigger/application.go
Outdated
| @@ -23,14 +25,25 @@ func (r *Application) Updated(m *model.Application) (err error) { | |||
| if !Settings.Discovery.Enabled { | |||
| return | |||
| } | |||
|
|
|||
| repo := model.Repository{} | |||
| err = json.Unmarshal(m.Repository, &repo) | |||
There was a problem hiding this comment.
This will be revisited when the JSON serialization work goes in.
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
discovery-require-repository
branch
from
a6a3aec
to
81b6daf
Compare
aufi
approved these changes
Jul 11, 2024
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.