-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Tasking find refs #673
👻 Tasking find refs #673
Conversation
…odel. Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
task/manager.go
Outdated
} | ||
kind, found := m.cluster.tasks[task.Kind] | ||
if !found { | ||
err = &ExtensionNotFound{Name: task.Kind} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be KindNotFound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
importer/manager.go
Outdated
@@ -356,19 +356,12 @@ func (m *Manager) createApplication(imp *model.Import) (ok bool) { | |||
|
|||
func (m *Manager) discover(application *model.Application) (err error) { | |||
for _, kind := range Settings.Hub.Discovery.Tasks { | |||
t := api.Task{} | |||
t := &tasking.Task{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underlying model.Task needs to be initialized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
b0a265f
to
c9bdc1c
Compare
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@@ -336,7 +327,7 @@ func (h TaskHandler) Delete(ctx *gin.Context) { | |||
// @description Update a task. | |||
// @tags tasks | |||
// @accept json | |||
// @success 202 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and patch probably should go back to being a 204
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems to work well and the performance problem is resolved. Just minor nit about put/patch return codes.
Looks like the tests might need to be adjusted to deal with delete/cancel being fully aync. |
Signed-off-by: Jeff Ortel <jortel@redhat.com>
E2E Test checkout is currently broken by my recent PR fixing diverged branches failures konveyor/go-konveyor-tests#132 The error looks to be caused by just using main branch API tests in E2E test suite, instead of updated tests in this PR. I will update CI scripts, meanwhile in this case, feel free go ahead with merging. |
This reverts commit 9b4cc38.
No description provided.