🌱 Add File and RuleSet API tests #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving File and RuleSet-related functions from addon package to binding package and adding basic API tests for both. Related to konveyor/go-konveyor-tests#2 Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
commented
Jun 19, 2023
addon/adapter.go
Outdated
| // | ||
| // Setting client in binding package via setter method. | ||
| adapter.File.SetClient(client) | ||
| adapter.RuleSet.SetClient(client) |
There was a problem hiding this comment.
Since client is not available outside the package (binding in this case), I added SetClient methods to allow set the client from addon package. Expecting its deletion when addon is migrated to binding.
There was a problem hiding this comment.
In the binding package, we could just make the client in all of the endpoint handlers public instead?
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving File and RuleSet-related functions from addon package to binding package and adding basic API tests for both.
Related to konveyor/go-konveyor-tests#2