Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Seeds: Missing space in description #376

Merged
merged 4 commits into from
Jun 12, 2023
Merged

✨ Seeds: Missing space in description #376

merged 4 commits into from
Jun 12, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jun 6, 2023

@gildub gildub requested review from aufi and jortel June 7, 2023 11:44
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gildub .
Updating in the v3 migration is good because it is the canonical definition of the seed (which we need to keep tack of). In konveyor 1.0 we have a redesign of the seeding mechanism that will make maintaining seeding much easier/better.

For upgrades, v3 will not be re-applied so this needs to be patched in v4.
Recommend adding (something like) to v4/migrate.go

func (r Migration) updateBundleSeed(db *gorm.DB) (err error) {
	db = db.Model(&model.RuleSet{})
	db = db.Where("Name", "Open Liberty")
	err = db.Update(
		"Description",
		"A comprehensive set of rules for migrating traditional WebSphere" +
			" applications to Open Liberty.").Error
	return
}

And calling at the end of Migration.Apply().

Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix error introduced while  resolving merge conflicts.
@jortel jortel merged commit 61f4d93 into konveyor:main Jun 12, 2023
@gildub gildub deleted the mta-500 branch June 13, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants