Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support: pagination, sorting, YAML bindings. #293

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Apr 12, 2023

POST/PUT/PATCH body format bind based on Content-Type (header) supporting both JSON and YAML.
GET body format rendered based on Accept (header) supporting both JSON and YAML. Defaults to JSON. Other MIMEs specified will be coerced to JSON.

Improves support for Accept header matching.

[1] https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html

Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. LGTM.

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Accept = api.Accept
AppJson = api.AppJson
AppOctet = api.AppOctet
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint: Use MIMEs in the binding package instead.

@jortel jortel merged commit 1732757 into konveyor:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants