✨ TagCategory API improvements #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortel
reviewed
Apr 10, 2023
addon/tag.go
Outdated
| @@ -59,7 +59,8 @@ func (h *Tag) Delete(r *api.Tag) (err error) { | |||
| // Find by name and type. | |||
| func (h *Tag) Find(name string, category uint) (r *api.Tag, found bool, err error) { | |||
| list := []api.Tag{} | |||
| err = h.client.Get(api.TagsRoot, &list) | |||
| path := Path(api.TagCategoryTagsRoot).Inject(Params{api.ID: r.ID}) | |||
There was a problem hiding this comment.
Shouldn't this be?
path := Path(api.TagCategoryTagsRoot).Inject(Params{api.ID: category})
jortel
reviewed
Apr 10, 2023
| @@ -59,7 +59,8 @@ func (h *Tag) Delete(r *api.Tag) (err error) { | |||
| // Find by name and type. | |||
| func (h *Tag) Find(name string, category uint) (r *api.Tag, found bool, err error) { | |||
| list := []api.Tag{} | |||
| err = h.client.Get(api.TagsRoot, &list) | |||
| path := Path(api.TagCategoryTagsRoot).Inject(Params{api.ID: r.ID}) | |||
| err = h.client.Get(path, &list, Param{Key: api.Name, Value: name}) | |||
| if err != nil { | |||
| return | |||
| } | |||
There was a problem hiding this comment.
Can't the loop and search following this be replaced with:
if len(list) > 0 {
found = true
r = &list[0]
}
jortel
reviewed
Apr 10, 2023
| @@ -143,7 +144,7 @@ func (h *TagCategory) Delete(r *api.TagCategory) (err error) { | |||
| // Find by name. | |||
| func (h *TagCategory) Find(name string) (r *api.TagCategory, found bool, err error) { | |||
| list := []api.TagCategory{} | |||
| err = h.client.Get(api.TagCategoriesRoot, &list) | |||
| err = h.client.Get(api.TagCategoriesRoot, &list, Param{Key: api.Name, Value: name}) | |||
| if err != nil { | |||
| return | |||
| } | |||
There was a problem hiding this comment.
Can't the loop and search following this be replaced with:
if len(list) > 0 {
found = true
r = &list[0]
}
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
aufi
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namequery parameter to/tagcategorieslist./tagcategories/:id/tagssubresource, with optionalnamequery parameter to filter.These
namequery parameters are a case sensitive exact match, which will result in the list containing either one or no entries.