Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 Addon error/activity reporting updated. SoftError deprecated. #39

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jul 25, 2023

Using latest hub addon binding error/activity reporting API.
Removed usage of SoftError.

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel changed the title 👻 Addon error/activity revisited. 👻 Addon error/activity reporting updated. SoftError deprecated. Jul 26, 2023
Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the prereq PR is merged

err = &SoftError{
Reason: "http URL used with snv.insecure.enabled = FALSE",
}
err = errors.New("http URL used with snv.insecure.enabled = FALSE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in "svn"

Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel marked this pull request as ready for review July 31, 2023 15:43
@jortel jortel merged commit fe8643c into konveyor:main Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants