Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Support incident selectors. #70

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Dec 20, 2023

Add support for incident selectors. Users can filter in/out incidents based on packages. The package is reported as an Incident.Variables with key=package.
The !package and !(package) syntax is used to match incidents without the package variable.

Passes --incident-selector option as needed.

Test cases and expected selector:

Case Selector
Empty
Included (only) (!package||package=a||package=b)
Included and Excluded (!package||package=a||package=b) && !(package=C||package=D)
Excluded (only) !(package||package=C||package=D)

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants