Skip to content

Commit

Permalink
✨ allow memory and CPU request for windup container to be customized (#…
Browse files Browse the repository at this point in the history
…237)

in the install-tackle action

Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
  • Loading branch information
fabianvf committed May 31, 2023
1 parent 24392ec commit fabe24a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/actions/install-tackle/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ inputs:
description: "Image Pull Policy"
required: false
default: "Always"
tackle-windup-container-cpu:
description: "The CPU request value for the windup task containers"
required: false
default: 0
tackle-windup-container-memory:
description: "The memory request value for the windup task containers"
required: false
default: 0
# TODO(djzager): uncomment when supported
# tackle-operator-container-image:
# description: "image url for operator container"
Expand All @@ -49,6 +57,8 @@ runs:
export TACKLE_ADDON_ADMIN_IMAGE="${{ inputs.tackle-addon-admin-image }}"
export TACKLE_ADDON_WINDUP_IMAGE="${{ inputs.tackle-addon-windup-image }}"
export TACKLE_IMAGE_PULL_POLICY="${{ inputs.tackle-image-pull-policy }}"
export TACKLE_WINDUP_CONTAINER_REQUESTS_MEMORY="${{ inputs.tackle-windup-container-memory }}"
export TACKLE_WINDUP_CONTAINER_REQUESTS_CPU="${{ inputs.tackle-windup-container-cpu }}"
make install-tackle
working-directory: ${{ github.action_path }}/../../..
shell: bash
4 changes: 4 additions & 0 deletions hack/install-tackle.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ TACKLE_UI_INGRESS_CLASS_NAME="${TACKLE_UI_INGRESS_CLASS_NAME:-nginx}"
TACKLE_ADDON_ADMIN_IMAGE="${TACKLE_ADDON_ADMIN_IMAGE:-quay.io/konveyor/tackle2-addon:latest}"
TACKLE_ADDON_WINDUP_IMAGE="${TACKLE_ADDON_WINDUP_IMAGE:-quay.io/konveyor/tackle2-addon-windup:latest}"
TACKLE_IMAGE_PULL_POLICY="${TACKLE_IMAGE_PULL_POLICY:-Always}"
TACKLE_WINDUP_CONTAINER_REQUESTS_MEMORY="${TACKLE_WINDUP_CONTAINER_REQUESTS_MEMORY:-0}"
TACKLE_WINDUP_CONTAINER_REQUESTS_CPU="${TACKLE_WINDUP_CONTAINER_REQUESTS_CPU:-0}"

TACKLE_FEATURE_AUTH_REQUIRED="${TACKLE_FEATURE_AUTH_REQUIRED:-false}"

Expand Down Expand Up @@ -90,6 +92,8 @@ spec:
admin_fqin: ${TACKLE_ADDON_ADMIN_IMAGE}
windup_fqin: ${TACKLE_ADDON_WINDUP_IMAGE}
image_pull_policy: ${TACKLE_IMAGE_PULL_POLICY}
windup_container_requests_memory: ${TACKLE_WINDUP_CONTAINER_REQUESTS_MEMORY}
windup_container_requests_cpu: ${TACKLE_WINDUP_CONTAINER_REQUESTS_CPU}
EOF
# Wait for reconcile to finish
kubectl wait \
Expand Down

0 comments on commit fabe24a

Please sign in to comment.