Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Allow logging to disk #237

Merged
merged 5 commits into from
Jul 22, 2024
Merged

✨ Allow logging to disk #237

merged 5 commits into from
Jul 22, 2024

Conversation

jwmatthews
Copy link
Member

@jwmatthews jwmatthews commented Jul 18, 2024 •
edited
Loading

This will:

  • Introduce logging to a File
  • Split out log levels for Console or File
  • Fix podman compose logging so it writes to our local disk and not into the containers ephemeral storage

Misc:

@jwmatthews jwmatthews changed the title 👻 WIP logging updates 👻 Allow logging to disk Jul 18, 2024
@jwmatthews jwmatthews changed the title 👻 Allow logging to disk ✨ Allow logging to disk Jul 18, 2024
@jwmatthews jwmatthews marked this pull request as ready for review July 18, 2024 22:03
@jwmatthews
WIP logging updates
7600167 
Signed-off-by: John Matthews <jwmatthews@gmail.com>
@jwmatthews
Logging to disk via podman compose working
171f5d8 
Signed-off-by: John Matthews <jwmatthews@gmail.com>
@jwmatthews
Tweak to log levels
c201300 
Signed-off-by: John Matthews <jwmatthews@gmail.com>
@jwmatthews
Cleanup tweaks
0f6b9dd 
Signed-off-by: John Matthews <jwmatthews@gmail.com>
@jwmatthews
Ensure 'load-data' from podman compose up can log to disk
ebf06f1 
Signed-off-by: John Matthews <jwmatthews@gmail.com>
fabianvf
fabianvf approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jmontleon
jmontleon approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@jmontleon jmontleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

JonahSussman
JonahSussman approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JonahSussman JonahSussman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonahSussman JonahSussman merged commit ece6b12 into konveyor:main Jul 22, 2024
3 checks passed
This was referenced Jul 22, 2024
Closed
Closed
@jwmatthews jwmatthews deleted the log_to_file branch July 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmontleon jmontleon jmontleon approved these changes

@fabianvf fabianvf fabianvf approved these changes

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

@JonahSussman JonahSussman JonahSussman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwmatthews @jmontleon @fabianvf @pranavgaikwad @JonahSussman