-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Upload binary administracion efectivo to TIER0 #166
Moving Upload binary administracion efectivo to TIER0 #166
Conversation
{ | ||
Provider: "java", | ||
Name: "itext-2.1.7.js2.jar", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a valid dependency? There is no version/labels/sha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This most likely means that it is a jar file that is packaged in the jar, and referenced that way IIRC.
@pranavgaikwad @jmle is that correct?
27eb0b9
to
2142693
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct to me
c639060
to
1075d56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Recommeding merging when CI/tier0 is green even the error looks unrelated to this PR.
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
1075d56
to
c242ae6
Compare
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Since this issue should be fixed: https://issues.redhat.com/browse/MTA-2606
We can use CI to validate this.