Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Upload binary administracion efectivo to TIER0 #166

Merged

Conversation

mguetta1
Copy link
Collaborator

Since this issue should be fixed: https://issues.redhat.com/browse/MTA-2606
We can use CI to validate this.

@mguetta1 mguetta1 requested review from aufi and dymurray July 29, 2024 20:02
Comment on lines +272 to +275
{
Provider: "java",
Name: "itext-2.1.7.js2.jar",
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a valid dependency? There is no version/labels/sha

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This most likely means that it is a jar file that is packaged in the jar, and referenced that way IIRC.
@pranavgaikwad @jmle is that correct?

@mguetta1 mguetta1 force-pushed the upload-binary-administracion-efectivo branch from 27eb0b9 to 2142693 Compare August 5, 2024 06:20
@mguetta1 mguetta1 requested a review from sshveta August 28, 2024 08:05
@mguetta1 mguetta1 added the cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch. label Aug 28, 2024
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me

@mguetta1 mguetta1 force-pushed the upload-binary-administracion-efectivo branch from c639060 to 1075d56 Compare August 29, 2024 09:15
@mguetta1 mguetta1 added cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. and removed cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. labels Aug 29, 2024
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Recommeding merging when CI/tier0 is green even the error looks unrelated to this PR.

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1 mguetta1 force-pushed the upload-binary-administracion-efectivo branch from 1075d56 to c242ae6 Compare September 3, 2024 17:59
@mguetta1 mguetta1 merged commit 08a5f21 into konveyor:main Sep 3, 2024
6 of 7 checks passed
@mguetta1 mguetta1 deleted the upload-binary-administracion-efectivo branch September 3, 2024 18:34
mguetta1 added a commit to mguetta1/go-konveyor-tests that referenced this pull request Sep 3, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1 added a commit that referenced this pull request Sep 4, 2024
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. cherry-pick/release-0.5 This PR should be cherry-picked to release-0.4 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants