✨ Get pod list #154
Closed
✨ Get pod list #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/get-podlist
branch
from
7579759
to
7b8caf0
Compare
aufi
reviewed
Jul 10, 2024
| @@ -23,7 +23,7 @@ jobs: | |||
| uses: konveyor/tackle2-operator/.github/actions/install-tackle@main | |||
| - uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: '1.19' | |||
| go-version: '1.22' | |||
There was a problem hiding this comment.
No big deal, but I'd prefer use the same go versions for on-PR and nightly-executed workflows.
There was a problem hiding this comment.
Yeah this was a change that had to be reverted sorry about leaving that in
| cl, err := client.New(config.GetConfigOrDie(), client.Options{}) | ||
| if err != nil { | ||
| t.Fatalf("failed to create client: %v", err) | ||
| } |
There was a problem hiding this comment.
I'd suggest make this optional (use an env variable like KUBEDEBUG similar to https://github.com/konveyor/go-konveyor-tests?tab=readme-ov-file#test-execution-options, or just skip if client creation failed).
I'm sure it brings value for debugging, but not each test execution (e.g. local or jenkins) has available KUBECONFIG.
There was a problem hiding this comment.
That is good point, will make the change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are failing to run tasks, getting the pods will help determine what is happening.