Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👻 count analysis tags only. #137

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Jun 25, 2024

Compare tag counts with gotTags instead of gotApp.Tags because gotApp.Tags contains non-analysis tags such as tags added by discovery.

I don't know why gofmt reformatted those indents.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel force-pushed the fix-analysis-test-tag-count branch from 1f1e79f to 84a329f Compare June 26, 2024 21:11
@djzager djzager merged commit 34e46ff into konveyor:main Jun 26, 2024
4 of 5 checks passed
djzager added a commit to djzager/go-konveyor-tests that referenced this pull request Jul 3, 2024
djzager added a commit to djzager/go-konveyor-tests that referenced this pull request Jul 3, 2024
This reverts commit 34e46ff.

Signed-off-by: David Zager <dzager@redhat.com>
@djzager djzager mentioned this pull request Jul 3, 2024
djzager added a commit that referenced this pull request Jul 3, 2024
* Revert "fixing test effort when we remove false postives (#146)"

This reverts commit 4bbf075.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert "adding workflow dispatch for tier 0 tests (#145)"

This reverts commit 4e334ac.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert "Moving Tomcat analysis TC to TIER0 (#125)"

This reverts commit 19ad9b7.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert "Updating hub deps (#138)"

This reverts commit 44cdaf7.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert ":ghost: count analysis tags only. (#137)"

This reverts commit 34e46ff.

Signed-off-by: David Zager <dzager@redhat.com>

---------

Signed-off-by: David Zager <dzager@redhat.com>
shawn-hurley pushed a commit to shawn-hurley/go-konveyor-tests that referenced this pull request Jul 3, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
shawn-hurley added a commit that referenced this pull request Jul 3, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Co-authored-by: Jeff Ortel <jortel@redhat.com>
msajidmansoori12 pushed a commit to msajidmansoori12/go-konveyor-tests that referenced this pull request Jul 9, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
msajidmansoori12 pushed a commit to msajidmansoori12/go-konveyor-tests that referenced this pull request Jul 9, 2024
* Revert "fixing test effort when we remove false postives (konveyor#146)"

This reverts commit 4bbf075.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert "adding workflow dispatch for tier 0 tests (konveyor#145)"

This reverts commit 4e334ac.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert "Moving Tomcat analysis TC to TIER0 (konveyor#125)"

This reverts commit 19ad9b7.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert "Updating hub deps (konveyor#138)"

This reverts commit 44cdaf7.

Signed-off-by: David Zager <dzager@redhat.com>

* Revert ":ghost: count analysis tags only. (konveyor#137)"

This reverts commit 34e46ff.

Signed-off-by: David Zager <dzager@redhat.com>

---------

Signed-off-by: David Zager <dzager@redhat.com>
msajidmansoori12 pushed a commit to msajidmansoori12/go-konveyor-tests that referenced this pull request Jul 9, 2024
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Co-authored-by: Jeff Ortel <jortel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants