Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests examples suite organization #16

Merged
merged 11 commits into from
Feb 14, 2024

Conversation

Jason-Gregoire
Copy link
Member

@Jason-Gregoire Jason-Gregoire commented Feb 13, 2024

Added 61 unit tests
Added and organized a comprehensive examples directory covering all common accumulate use cases
Refactored code where warranted
Updated/Added readme files

@sigrlami
Copy link
Member

Ok,

  • everything under .dart_tool is a debris. It's not a part of the source code per se but the execution system
  • // on top of the file with the path is debris also
  • spaces additions, splitting a single line of code into 2, adding "/" or not adding, in the end, this type of "refactoring" is highly controversial. In other environments will easily lead to "holy war". Good practice to use decisions already made in the repo.
  • when working with code, we tried to use the conventional commits practice https://www.conventionalcommits.org/en/v1.0.0-beta.2/ I would suggest using that in the future.

Copy link
Member

@sigrlami sigrlami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You can be the admin, no need to fork and request reviews. Just branch from this repo and self-approve PRs.

@Jason-Gregoire Jason-Gregoire merged commit 558725a into kompendium-ano:master Feb 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants