Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clicking on edit existing profile opens wrong modal state #10587

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: Clicking on edit existing profile opens wrong modal state #10587

merged 2 commits into from
Jul 8, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jul 5, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

issue: initial step was being set on modal close on not when opening the modal

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;
CleanShot.2024-07-05.at.12.04.21.mp4

@hassnian hassnian requested a review from a team as a code owner July 5, 2024 07:05
@hassnian hassnian requested review from preschian and Jarsen136 and removed request for a team July 5, 2024 07:05
@netlify Netlify
Copy link

netlify bot commented Jul 5, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c632646
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/668bb11b4cfc8e0008a20730
😎 Deploy Preview https://deploy-preview-10587--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jarsen136
Jarsen136 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Jul 5, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit c632646 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival
Copy link
Member

vikiival commented Jul 8, 2024

Why did the app make hard reload? (6th sec on video)

@hassnian
Copy link
Contributor Author

hassnian commented Jul 8, 2024 •
edited
Loading

Why did the app make hard reload? (6th sec on video)

I reloaded the page with the shortcut

@vikiival vikiival added this pull request to the merge queue Jul 8, 2024
Merged via the queue into kodadot:main with commit cdf21c9 Jul 8, 2024
19 checks passed
This was referenced Jul 13, 2024
Merged
Closed
Merged
Merged
Merged
This was referenced Aug 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on edit existing profile opens wrong modal state
4 participants
@hassnian @vikiival @preschian @Jarsen136