Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add drop-checker page #10578

Merged
merged 13 commits into from
Jul 16, 2024
Merged

chore: add drop-checker page #10578

merged 13 commits into from
Jul 16, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Jul 4, 2024

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Demo: https://deploy-preview-10578--koda-canary.netlify.app/drop-checker/ahp/158

Screenshot 2024-07-11 at 16 59 28

@preschian preschian requested a review from a team as a code owner July 4, 2024 10:59
Copy link

cloudflare-workers-and-pages bot commented Jul 4, 2024

Deploying koda-art-prod with  Cloudflare Pages  Cloudflare Pages

Latest commit: c8363c7
Status:⚡️  Build in progress...

View logs

@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team July 4, 2024 10:59
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c8363c7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66962497d63c0a0008c7bcb2
😎 Deploy Preview https://deploy-preview-10578--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

vikiival commented Jul 4, 2024

Scr?

@preschian preschian marked this pull request as draft July 10, 2024 09:01
@preschian preschian marked this pull request as ready for review July 11, 2024 10:04
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool

@vikiival vikiival requested a review from hassnian July 13, 2024 06:00
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

just a thought, what if we added ❌ or ✅ if the onchain and database data was === similar to what we do in the code-cheker

CleanShot 2024-07-13 at 12 26 23@2x

small darkmoda stuff

CleanShot 2024-07-13 at 12 17 22@2x

can't see the text here
CleanShot 2024-07-13 at 12 14 36@2x

@exezbcz
Copy link
Member

exezbcz commented Jul 14, 2024

looks good, where can i access the page?

@vikiival
Copy link
Member

looks good, where can i access the page?

Demo: https://deploy-preview-10578--koda-canary.netlify.app/drop-checker/ahp/158

so <url>/drop-checker/<prefix>/<id>

@preschian
Copy link
Member Author

just a thought, what if we added ❌ or ✅ if the onchain and database data was === similar to what we do in the code-cheker

added 👍🏻

small darkmoda stuff
can't see the text here

fixed

@preschian preschian requested a review from hassnian July 15, 2024 08:24
@vikiival vikiival requested a review from Jarsen136 July 15, 2024 13:02
Copy link

codeclimate bot commented Jul 16, 2024

Code Climate has analyzed commit c8363c7 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jul 16, 2024

@preschian preschian added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 408ae25 Jul 16, 2024
18 of 20 checks passed
@preschian preschian deleted the chore--add-drop-checker-page branch July 16, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants