Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 collection mobile #10573

Merged
merged 11 commits into from
Jul 13, 2024
Merged

🔧 collection mobile #10573

merged 11 commits into from
Jul 13, 2024

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jul 3, 2024

PR Type

  • Refactoring
  • css to tailwind

Needs Design check

Needs QA check

  • @kodadot/qa-guild please review

Context

Screenshot 📸

Capture d’écran 2024-07-03 à 12 52 17 PM

@roiLeo roiLeo requested a review from a team as a code owner July 3, 2024 10:54
@roiLeo roiLeo requested review from Jarsen136 and hassnian and removed request for a team July 3, 2024 10:54
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 38f0472
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/668e2c3bfe69a90008aab6ce
😎 Deploy Preview https://deploy-preview-10573--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up of #10564 , profile banner skeleton needs to be updated

can you also fix this here?.

thanks

CleanShot 2024-07-04 at 14 58 19

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 4, 2024

Capture d’écran 2024-07-04 à 2 00 06 PM

@hassnian
Copy link
Contributor

hassnian commented Jul 5, 2024

size looks right, but it's a bitt off, it's jumping

CleanShot 2024-07-05 at 14 03 39

@hassnian hassnian added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 5, 2024
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something broke

hassnian

This comment was marked as duplicate.

@hassnian
Copy link
Contributor

hassnian commented Jul 6, 2024

CleanShot 2024-07-06 at 09 35 09@2x

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 8, 2024

profile picture scale down, from 144px to 100px, centered vertically in the banner

where does the 40px padding comes from and where it need to be added?

@hassnian
Copy link
Contributor

hassnian commented Jul 10, 2024

checked canary and it has the same issues, would appreciate if you could fix them , thanks

profile

desktop

  1. image banner padding should be (40px)
  2. profile title should be 31px
CleanShot.2024-07-10.at.09.59.40.mp4

mobile

LGTM

Copy link

codeclimate bot commented Jul 10, 2024

Code Climate has analyzed commit 38f0472 and detected 0 issues on this pull request.

View more on Code Climate.

@roiLeo
Copy link
Contributor Author

roiLeo commented Jul 10, 2024

profile

desktop

1. image banner padding should be (40px)
2. profile title should be 31px

thank you for these clarifications, should be good now.
IMO it would be better to customize tailwind fontSize class than have specific size.

@hassnian
Copy link
Contributor

thank you for these clarifications, should be good now.

looking good, thanks!

IMO it would be better to customize tailwind fontSize class than have specific size.

if you want #10611 :)

@vikiival vikiival removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 13, 2024
@vikiival vikiival added this pull request to the merge queue Jul 13, 2024
Merged via the queue into kodadot:main with commit e5bffd8 Jul 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collection mobile followup
4 participants