Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParaSpell to v5.6.0 #10560

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Update ParaSpell to v5.6.0 #10560

merged 2 commits into from
Jul 3, 2024

Conversation

dudo50
Copy link
Contributor

@dudo50 dudo50 commented Jul 1, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

Needs QA check

Context

The following PR features ParaSpell v5.6.0 which brought many useful features such as custom multilocations, customizable xcm version, Polkadot<>Kusama bridge and many more..

Along with features it brought many safety advancements such updating every package used in SDK to latest version.

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases
  • Tested on main net

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@dudo50 dudo50 requested a review from a team as a code owner July 1, 2024 10:52
@dudo50 dudo50 requested review from preschian and hassnian and removed request for a team July 1, 2024 10:52
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 18a9a7d
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6683f5cad960ed0008ec3265
😎 Deploy Preview https://deploy-preview-10560--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival
Copy link
Member

vikiival commented Jul 1, 2024

Hey, Is there any breaking change?

@dudo50
Copy link
Contributor Author

dudo50 commented Jul 1, 2024

Hey @vikiival , no, there isn't, we have locally tested SDK on your project and everything works as expected.

Copy link

codeclimate bot commented Jul 2, 2024

Code Climate has analyzed commit 18a9a7d and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival added this pull request to the merge queue Jul 3, 2024
Merged via the queue into kodadot:main with commit 502494f Jul 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants