Issue #28, StandardizedErrorReason class #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koaning
reviewed
Dec 20, 2021
koaning
requested changes
Dec 20, 2021
There was a problem hiding this comment.
There's a few minor items to tick off.
- The
readme.mdfile and as well the quickstart guide in the docs list all the reasons in the package. Feel free to add this new one. - If you have a look at some of the classifier reasons like this one you'll notice that a
from_predictmethod is implemented. This is nice to have because the end user can calculate the predictions once and re-use them across reasons. It also makes it much easier to write unit tests. Could you add such a method as well as a unit test?
koaning
reviewed
Dec 20, 2021
koaning
requested changes
Dec 20, 2021
koaning
approved these changes
Dec 21, 2021
|
Grand! Let's merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
StandardizedErrorReasonclass for regression tasks, as disccussed in issue #28Other file changes are due to black formatting