fix cache

[dislido]

should be the same as line 96

fix #69

Checklist

• I have ensured my pull request is not behind the main or master branch of the original repository.
• I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
• I have written a commit message that passes commitlint linting.
• I have ensured that my code changes pass linting tests.
• I have ensured that my code changes pass unit tests.
• I have described my pull request and the reasons for code changes along with context if necessary.

[midnight-wonderer]

Guys @titanism , @3imed-jaberi (Pinging you two because you are the latest active.)
Could you take a quick look at this pull request? It should be a quick merge, IMO. And probably release ASAP.

Let me explain

  async function render (view, options) {
    view += settings.viewExt
    const viewPath = path.join(settings.root, view)
    debug(`render: ${viewPath}`)
    // get from cache
    if (settings.cache && cache[viewPath]) return cache[viewPath](options.scope, options)

    const tpl = await settings.fs.readFile(viewPath, 'utf8')

    const fn = ejs.compile(tpl, {
      filename: viewPath,
      _with: settings._with,
      compileDebug: settings.debug && settings.compileDebug,
      debug: settings.debug,
      delimiter: settings.delimiter,
      cache: settings.cache,
      async: settings.async,
      outputFunctionName: settings.outputFunctionName
    })
    if (settings.cache) cache[viewPath] = fn
    return fn.call(options.scope, options)
  }

This function does roughly three things

• Cache lookup

if (settings.cache && cache[viewPath])

• If nothing is in the cache, put things in the cache.

cache[viewPath] = fn

• execute what was cached

fn.call(options.scope, options)

But the way to execute what was cached is inconsistent
we have

return cache[viewPath](options.scope, options)

vs

fn.call(options.scope, options)

The first one is broken; they should be the same, hence, the pull request.

[titanism]

v5.1.0 released

https://github.com/koajs/ejs/releases/tag/v5.1.0