Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[597-Fix] Profilbilde i header #599

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[597-Fix] Profilbilde i header #599

merged 3 commits into from
Jun 25, 2024

Conversation

joacimds
Copy link
Collaborator

Hva løser oppgaven:

I produksjon ble ikke profilbildet til den innloggede brukeren hentet.

Hvordan er oppgaven løst:

  • Henter employeeProfile-data i den samme useEffecten som userInfo blir hentet, i stedet for å håndteres det i to ulike useEffects. Unødvendig når den ene useEffecten er avhengig av resultatet fra kallet som henter userInfo.
  • Også oppdatert launch.json, fordi webRoot definert der var feil.

@joacimds joacimds added the enhancement New feature or request label Jun 24, 2024
@joacimds joacimds requested a review from TirilS June 24, 2024 07:35
@joacimds joacimds self-assigned this Jun 24, 2024
@joacimds joacimds requested review from HovdeRuneKnowit and removed request for TirilS June 25, 2024 12:15
HovdeRuneKnowit
HovdeRuneKnowit approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@HovdeRuneKnowit HovdeRuneKnowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joacimds joacimds merged commit d49d9f8 into master Jun 25, 2024
2 checks passed
@joacimds joacimds deleted the feature/597-profilbilde-i-heading branch June 25, 2024 12:23
@joacimds joacimds linked an issue Jun 26, 2024 that may be closed by this pull request
Erstatte Forbokstav/standard ikon med Profilbilde i heading #597
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HovdeRuneKnowit HovdeRuneKnowit HovdeRuneKnowit approved these changes

Assignees

@joacimds joacimds

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erstatte Forbokstav/standard ikon med Profilbilde i heading
2 participants
@joacimds @HovdeRuneKnowit