Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from k8s.gcr.io to registry.k8s.io #1342

Conversation

shikharcodes
Copy link

This PR is a part of kubernetes/k8s.io#4780.

Proposed Changes

This PR does the following changes:

  • modify all occurrences of k8s.gcr.io to registry.k8s.io.

Release Note

NONE

Signed-off-by: Shikhar Saxena <shikhar06jan@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shikharcodes
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Feb 17, 2023

Welcome @shikharcodes! It looks like this is your first PR to knative/operator 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2023
@knative-prow knative-prow bot requested a review from aliok February 17, 2023 18:34
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 17, 2023

Hi @shikharcodes. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@houshengbo
Copy link
Contributor

Do not change anything under cmd/operator/kodata manually, because this direction is updated automatically with the script. If you propose some changes to the files in this directory, please submit changes to each repo.

For example, if you would like to change cmd/operator/kodata/eventing-source/1.6/ceph/ceph.yaml, please submit the PR to the repo: https://github.com/knative-sandbox/eventing-ceph.
Once all the other repos are updated, operator is able to pull the changes.

@shikharcodes
Copy link
Author

Do not change anything under cmd/operator/kodata manually, because this direction is updated automatically with the script. If you propose some changes to the files in this directory, please submit changes to each repo.

For example, if you would like to change cmd/operator/kodata/eventing-source/1.6/ceph/ceph.yaml, please submit the PR to the repo: https://github.com/knative-sandbox/eventing-ceph. Once all the other repos are updated, operator is able to pull the changes.

Thanks @houshengbo, I'll take a look as suggested.

@ahmedwaleedmalik
Copy link

@houshengbo all the corresponding PRs have been merged.

@shikharcodes based on "updated automatically with the script", I think we can close this PR and mark it as done :)

@houshengbo houshengbo closed this Apr 25, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants