feat: enable Paketo builders for Python functions #979
Conversation
This commit changes the Python functions to use the open source Paketo builders. The Paketo builders allow the use of a Procfile to indicate the desired default start process for the container, so this has been added to invoke Parliament at startup. Also, there were no README.md files for Python, so I added them too. Signed-off-by: Lance Ball <lball@redhat.com>
knative-prow
bot
added
kind/enhancement
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 57 57
Lines 7458 7458
=======================================
Hits 3435 3435
Misses 3697 3697
Partials 326 326 Continue to review full report at Codecov.
|
|
/lgtm |
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
|
@lance I was too fast here. Python e2e test is failing, but I cannot see reason for it. |
|
cc @jrangelramos ^^^ |
|
@lkingland do you any idea what could have gone wrong? |
|
While I can not know for sure, we do have a theory. We have been seeing this every once in a while over the past few week. Jefferson added some additional debugging to the E2E tests, so we can hopefully get more information, but right now it appears these are test flakiness due to a timeout somewhere in the underlying system. It often resolves itself by re-running the failed test. Note the error message |
|
Well, it failed 3 times in row. |
|
4 times if we count failure in midstream. |
|
5th failure 😢 |
|
Yea it needs to update the template used on e2e for new revision check. |
Changes
This commit changes the Python functions to use the open source Paketo builders. The Paketo builders allow the use of a Procfile to indicate the desired default start process for the container, so this has been added to invoke Parliament at startup.
Also, there were no README.md files for Python, so I added them too.
/kind enhancement
Fixes: #977
Release Note