-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update manifest.yamls #846
chore: update manifest.yamls #846
Conversation
In a couple of cases, the `invoke` parameter was missing. And there was an outdated use of a typescript buildpack in the typescript/cloudevent templates. Signed-off-by: Lance Ball <lball@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lance were are the TS changes? |
/hold |
Signed-off-by: Lance Ball <lball@redhat.com>
@matejvasek here: 462696f |
I learned obsessively press CTRL+S everywhere 😄 |
Codecov Report
@@ Coverage Diff @@
## main #846 +/- ##
=======================================
Coverage 43.36% 43.36%
=======================================
Files 48 48
Lines 4690 4690
=======================================
Hits 2034 2034
Misses 2367 2367
Partials 289 289 Continue to review full report at Codecov.
|
/unhold |
/lgtm |
Changes
invoke
parameter was missing.Signed-off-by: Lance Ball lball@redhat.com
/kind bug
Release Note