Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update manifest.yamls #846

Merged
merged 2 commits into from
Feb 22, 2022
Merged

chore: update manifest.yamls #846

merged 2 commits into from
Feb 22, 2022

Conversation

lance
Copy link
Member

@lance lance commented Feb 22, 2022

Changes

  • 🐛 In a couple of cases, the invoke parameter was missing.
  • 🐛 There was an outdated use of a typescript buildpack in the typescript/cloudevent templates.

Signed-off-by: Lance Ball lball@redhat.com

/kind bug

Release Note

Fixes missing `cloudevent` invocation format for Node.js, SpringBoot and Rust CloudEvent templates

@lance
chore: update manifest.yamls
e396875 
In a couple of cases, the `invoke` parameter was missing. And there was an
outdated use of a typescript buildpack in the typescript/cloudevent templates.

Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow-robot knative-prow-robot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2022
@matejvasek
Copy link
Contributor

@lance were are the TS changes?

@matejvasek
Copy link
Contributor

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2022
@lance
fixup: I should set VSCode to autosave on focus change
462696f 
Signed-off-by: Lance Ball <lball@redhat.com>
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2022
@lance
Copy link
Member Author

lance commented Feb 22, 2022

@matejvasek here: 462696f

@matejvasek
Copy link
Contributor

fixup: I should set VSCode to autosave on focus change

I learned obsessively press CTRL+S everywhere 😄

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #846 (462696f) into main (5fad42b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   43.36%   43.36%           
=======================================
  Files          48       48           
  Lines        4690     4690           
=======================================
  Hits         2034     2034           
  Misses       2367     2367           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fad42b...462696f. Read the comment docs.

@matejvasek
Copy link
Contributor

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2022
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2022
@knative-prow-robot knative-prow-robot merged commit ad42f3a into knative:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lance @knative-prow-robot @matejvasek