Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podman guide #836

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix podman guide #836

merged 1 commit into from
Feb 17, 2022

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Feb 17, 2022 •
edited by lance 

Clarify podman requirements on Linux vs. MacOS and Linux in podman.md guide

/kind documentation

@matejvasek
Fix podman guide
14a7e6a 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2022
@matejvasek
Copy link
Contributor Author

cc @rh-max

@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited

Codecov Report

Merging #836 (14a7e6a) into main (72d9b7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #836   +/-   ##
=======================================
  Coverage   43.36%   43.36%           
=======================================
  Files          48       48           
  Lines        4690     4690           
=======================================
  Hits         2034     2034           
  Misses       2367     2367           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72d9b7d...14a7e6a. Read the comment docs.

lance
lance reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022
@knative-prow-robot knative-prow-robot merged commit f25724a into knative:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance left review comments

@zroubalik zroubalik Awaiting requested review from zroubalik

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lance lance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matejvasek @knative-prow-robot @lance