Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defaults for prompt from flags then options #821

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Feb 7, 2022

  • 🐛 select prompt option based on flag or default

Fixes #819
Fixes #820

Related issue #814

/kind bug

Fix a bug where interactive prompt defaults were not being used

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 7, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2022
@lkingland lkingland force-pushed the lkingland/survey-prompt-flag-defaults branch from db87141 to a8a79e0 Compare February 7, 2022 23:36
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #821 (a8a79e0) into main (879031a) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   42.85%   42.79%   -0.06%     
==========================================
  Files          47       47              
  Lines        4749     4755       +6     
==========================================
  Hits         2035     2035              
- Misses       2422     2428       +6     
  Partials      292      292              
Impacted Files Coverage Δ
cmd/create.go 46.21% <ø> (ø)
cmd/invoke.go 32.36% <0.00%> (-0.14%) ⬇️
cmd/root.go 64.49% <0.00%> (-2.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 879031a...a8a79e0. Read the comment docs.

@lkingland lkingland self-assigned this Feb 7, 2022
@lkingland lkingland requested a review from lance February 7, 2022 23:40
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2022
@knative-prow-robot knative-prow-robot merged commit 5b06498 into knative:main Feb 9, 2022
@lkingland lkingland deleted the lkingland/survey-prompt-flag-defaults branch September 20, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants