Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a label to every resouce created for a Function #757

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

zroubalik
Copy link
Contributor

@zroubalik zroubalik commented Jan 12, 2022

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Adding a label function.knative.dev/name: functionName to every resouce created for a Function, so we can easily identify them.

Changes

  • 🎁 add a label to every resouce created for a Function

/kind enhancement

Fixes: #753

Adds a label `function.knative.dev/name: functionName` to every resouce created for a Function

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 12, 2022
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #757 (2f2ea6a) into main (f06fd97) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   41.40%   41.39%   -0.01%     
==========================================
  Files          44       44              
  Lines        4176     4177       +1     
==========================================
  Hits         1729     1729              
- Misses       2191     2192       +1     
  Partials      256      256              
Impacted Files Coverage Δ
knative/deployer.go 5.58% <0.00%> (-0.02%) ⬇️
knative/lister.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06fd97...2f2ea6a. Read the comment docs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2022
…souce created for a Function

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2022
@matejvasek
Copy link
Contributor

/lgtm
/hold until test pass

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022
@matejvasek
Copy link
Contributor

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022
@knative-prow-robot knative-prow-robot merged commit bddac30 into knative:main Jan 13, 2022
jrangelramos added a commit to jrangelramos/func that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On-cluster build: Add kubernetes labels to resources created for Pipeline
3 participants