Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: rename event templates to 'cloudevents' #584

Merged
merged 6 commits into from
Oct 13, 2021
Merged

feat!: rename event templates to 'cloudevents' #584

merged 6 commits into from
Oct 13, 2021

Conversation

lance
Copy link
Member

@lance lance commented Oct 13, 2021

Changes

🧹 This commit renames the templates for cloudevents to be named "cloudevents".

BREAKING CHANGE

/kind enhancement

Fixes: #578

Release Note

action required
When creating new function projects using the built in templates, you must now specify "cloudevents" instead of "events" to create an event based project.

@lance
feat!: rename event templates to 'cloudevents'
5658a28 
This commit renames the templates for cloudevents to be named "cloudevents".

BREAKING CHANGE

Signed-off-by: Lance Ball <lball@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 13, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2021
@lance
fixup: update commands.md doc
88f2c1c 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance
fixup: fix make test-templates
ade0d88 
Signed-off-by: Lance Ball <lball@redhat.com>
matejvasek
matejvasek reviewed Oct 13, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@matejvasek
Copy link
Contributor 

// test/_e2e/trigger_events_test.go:61
func DefaultFunctionEventsTest(t *testing.T, knFunc *TestShellCmdRunner, project FunctionTestProject) {
	if project.Template == "events" && project.IsDeployed {

@matejvasek
Copy link
Contributor

@lance is seems that there are still some occurrences of event ^^^

@lance
fixup: missed an e2e test change
23f1a0d 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance
Copy link
Member Author

lance commented Oct 13, 2021

@lance is seems that there are still some occurrences of event ^^^

@matejvasek good catch - ty. I've added a failure in DefaultFunctionEventsTest() in the event that the if condition there fails again for some reason in the future.

@matejvasek
Copy link
Contributor

and there is .../events/.. also in .gitignore.

@lance
fixup: gitignore and pkged.go
2bd8220 
Signed-off-by: Lance Ball <lball@redhat.com>
@matejvasek
Copy link
Contributor

In Makefile recipe for pkged.go: there is also occurrence of /events/
https://github.com/lance/func/blob/lance/578-rename-events-template/Makefile#L66-L77

@lance
fixup: adjust Makefile recipe for pkged.go
e27368d 
Signed-off-by: Lance Ball <lball@redhat.com>
@matejvasek
Copy link
Contributor

/hold
until CI pass

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@matejvasek
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@lance
Copy link
Member Author

lance commented Oct 13, 2021

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2021
@knative-prow-robot knative-prow-robot merged commit 68b0904 into knative:main Oct 13, 2021
This was referenced Oct 14, 2021
Closed
Closed
lkingland pushed a commit to lkingland/func that referenced this pull request Oct 20, 2021
@lance @drekar
feat!: rename event templates to 'cloudevents' (knative#584)
b7e3200 
* feat!: rename event templates to 'cloudevents'

This commit renames the templates for cloudevents to be named "cloudevents".

BREAKING CHANGE

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: update commands.md doc

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: fix make test-templates

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: missed an e2e test change

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: gitignore and pkged.go

Signed-off-by: Lance Ball <lball@redhat.com>

* fixup: adjust Makefile recipe for pkged.go

Signed-off-by: Lance Ball <lball@redhat.com>
@github-actions github-actions bot mentioned this pull request Nov 3, 2021
Merged
jrangelramos added a commit to jrangelramos/func that referenced this pull request May 31, 2023
@jrangelramos
chore: clustertask patch for devconsole create serverless function (k…
3fd47bb 
…native#584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek matejvasek left review comments

Assignees

@matejvasek matejvasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename template "events" to "cloudevents"
3 participants
@lance @knative-prow-robot @matejvasek