-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename event templates to 'cloudevents' #584
feat!: rename event templates to 'cloudevents' #584
Conversation
This commit renames the templates for cloudevents to be named "cloudevents". BREAKING CHANGE Signed-off-by: Lance Ball <lball@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
// test/_e2e/trigger_events_test.go:61
func DefaultFunctionEventsTest(t *testing.T, knFunc *TestShellCmdRunner, project FunctionTestProject) {
if project.Template == "events" && project.IsDeployed { |
@lance is seems that there are still some occurrences of |
Signed-off-by: Lance Ball <lball@redhat.com>
@matejvasek good catch - ty. I've added a failure in |
and there is |
Signed-off-by: Lance Ball <lball@redhat.com>
In Makefile recipe for |
Signed-off-by: Lance Ball <lball@redhat.com>
/hold |
/lgtm |
/unhold |
* feat!: rename event templates to 'cloudevents' This commit renames the templates for cloudevents to be named "cloudevents". BREAKING CHANGE Signed-off-by: Lance Ball <lball@redhat.com> * fixup: update commands.md doc Signed-off-by: Lance Ball <lball@redhat.com> * fixup: fix make test-templates Signed-off-by: Lance Ball <lball@redhat.com> * fixup: missed an e2e test change Signed-off-by: Lance Ball <lball@redhat.com> * fixup: gitignore and pkged.go Signed-off-by: Lance Ball <lball@redhat.com> * fixup: adjust Makefile recipe for pkged.go Signed-off-by: Lance Ball <lball@redhat.com>
Changes
🧹 This commit renames the templates for cloudevents to be named "cloudevents".
BREAKING CHANGE
/kind enhancement
Fixes: #578
Release Note