src!: revert bump to go 1.16 and template changes #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0a6f56.
This reverts commit 99f0122.
This reverts commit 6673395.
This reverts commit a31a6f6.
This reverts commit 11164bf.
This reverts commit 4db07b4.
This reverts commit 3bfc133.
This reverts commit 6cc0e67.
This reverts commit c2b2168.
This reverts commit acc56b0.
This reverts commit 895872a.
This reverts commit 1e3959c.
This reverts commit 7dc772e.
This reverts commit 63b7f11.
This reverts commit 876b0dd.
This reverts commit f006ab1.
This reverts commit 4d9d0a7.
This reverts commit e44c1ad.
This reverts commit 38874a4.
This reverts commit 4025460.
This reverts commit 512d4c2.
Signed-off-by: Lance Ball <lball@redhat.com>
matejvasek
approved these changes
May 12, 2021
|
lgtm |
lance
changed the title
zroubalik
approved these changes
May 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of problems arose when attempting to build this project for 1.15 as an inlined plugin for
kn. First,knis still on go 1.15. And second, the templates.tgz file is not included in source, so whenknis built and dependencies are pulled viago mod vendor, that file does not exist.This is the first of a couple of different PRs to address this situation. Assuming that the
knbuild will not bump to go 1.16 this build reverts to 1.15 and removes the changes to how we bundle templates.