Include go.sum in the Go CloudEvent template #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go.sum must be in place otherwise "go list -f {{.Incomplete}}"
returns true which breaks s2i build.
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/M
matejvasek
requested review from
matzew,
gauron99 and
lkingland
and removed request for
maximilien
|
@jrangelramos this should fix #2401 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
==========================================
+ Coverage 61.19% 66.70% +5.51%
==========================================
Files 130 130
Lines 15354 11940 -3414
==========================================
- Hits 9396 7965 -1431
+ Misses 5032 3014 -2018
- Partials 926 961 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go.sum must be in place otherwise "go list -f {{.Incomplete}}" returns true which breaks s2i build.