Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: springboot updater missing EOL #2433

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow knative-prow bot requested review from dsimansk and nainaz July 21, 2024 11:01
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2024
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @matzew

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (aed23cf) to head (091110d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2433      +/-   ##
==========================================
+ Coverage   61.19%   66.68%   +5.48%     
==========================================
  Files         130      130              
  Lines       15354    11940    -3414     
==========================================
- Hits         9396     7962    -1434     
+ Misses       5032     3016    -2016     
- Partials      926      962      +36     
Flag Coverage Δ
e2e-test 36.74% <ø> (-0.08%) ⬇️
e2e-test-oncluster 33.38% <ø> (-0.03%) ⬇️
e2e-test-oncluster-runtime 29.39% <ø> (?)
e2e-test-runtime-go 25.22% <ø> (?)
e2e-test-runtime-node 26.15% <ø> (?)
e2e-test-runtime-python 26.15% <ø> (?)
e2e-test-runtime-quarkus 26.25% <ø> (?)
e2e-test-runtime-rust 25.28% <ø> (?)
e2e-test-runtime-springboot 25.31% <ø> (?)
e2e-test-runtime-typescript 26.24% <ø> (?)
integration-tests 52.80% <ø> (+2.43%) ⬆️
unit-tests 50.94% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link

knative-prow bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 362bdf6 into knative:main Jul 22, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants