Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Springboot platform version to 3.3.2 #2430

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

chore: update Springboot platform version to 3.3.2

@knative-prow knative-prow bot requested review from nainaz and rhuss July 18, 2024 20:04
Copy link

knative-prow bot commented Jul 18, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2024
@matejvasek
Copy link
Contributor

/ok-to-test
/approve
/lgtm

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 19, 2024
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2024
Copy link

knative-prow bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: github-actions[bot], matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
Copy link

knative-prow bot commented Jul 19, 2024

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.62%. Comparing base (c093c38) to head (4779e07).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c093c38) and HEAD (4779e07). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (c093c38) HEAD (4779e07)
unit-tests-macos-latest 1 0
unit-tests-ubuntu-latest 1 0
e2e-test 1 0
integration-tests 1 0
unit-tests-windows-latest 1 0
e2e-test-oncluster 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2430       +/-   ##
===========================================
- Coverage   61.20%   50.62%   -10.59%     
===========================================
  Files         130      128        -2     
  Lines       15354    11932     -3422     
===========================================
- Hits         9397     6040     -3357     
- Misses       5031     5184      +153     
+ Partials      926      708      -218     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

@dsimansk @ReToCode plz override codecov/project

@matejvasek matejvasek force-pushed the update-springboot-platform-3.3.2 branch from 0c66ee7 to 4779e07 Compare July 19, 2024 17:40
@ReToCode
Copy link
Member

/override "codecov/project"

Copy link

knative-prow bot commented Jul 22, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: codecov/project

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matejvasek matejvasek closed this Jul 22, 2024
@matejvasek matejvasek deleted the update-springboot-platform-3.3.2 branch July 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants