Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PaC detection for Red Hat's Sandbox cluster #2429

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

The sandbox cluster installs PaC cm into tekton-pipelines NS.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for jrangelramos and nainaz July 18, 2024 17:25
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.68%. Comparing base (c093c38) to head (7776767).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2429      +/-   ##
==========================================
+ Coverage   61.20%   66.68%   +5.48%     
==========================================
  Files         130      130              
  Lines       15354    11940    -3414     
==========================================
- Hits         9397     7962    -1435     
+ Misses       5031     3016    -2015     
- Partials      926      962      +36     
Flag Coverage Δ
e2e-test 36.77% <0.00%> (-0.05%) ⬇️
e2e-test-oncluster 33.32% <0.00%> (+<0.01%) ⬆️
e2e-test-oncluster-runtime 29.39% <0.00%> (?)
e2e-test-runtime-go 25.20% <0.00%> (?)
e2e-test-runtime-node 26.15% <0.00%> (?)
e2e-test-runtime-python 26.15% <0.00%> (?)
e2e-test-runtime-quarkus 26.25% <0.00%> (?)
e2e-test-runtime-rust 25.29% <0.00%> (?)
e2e-test-runtime-springboot 25.33% <0.00%> (?)
e2e-test-runtime-typescript 26.24% <0.00%> (?)
integration-tests 52.74% <100.00%> (+2.38%) ⬆️
unit-tests 50.94% <0.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

@lkingland @gauron99 @matzew PTAL

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
Copy link

knative-prow bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit aed23cf into knative:main Jul 19, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants