Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter issues #2420

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix linter issues #2420

merged 3 commits into from
Jul 9, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 9, 2024

  • Fixed typos
  • Removed some SuggestFor in cobra commands since the auto-suggest functionality works just all right.
  • Removed trailing whitespaces
  • Added EoLs at EoFs

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2024
@@ -37,8 +37,7 @@ DESCRIPTION
the version of func, the version of the function spec, the default builder,
available runtimes, and available templates.
`,
SuggestFor: []string{"env", "environemtn", "enviroment", "enviornment", "enviroment"},
Copy link
Contributor Author

@matejvasek matejvasek Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo-detect-hint works out-of-the box. So I deleted it.

@@ -56,11 +56,6 @@ EXAMPLES
o Return Go templates in a specific repository
$ {{rootCmdUse}} templates go --repository=https://github.com/boson-project/templates
`,
SuggestFor: []string{"template", "templtaes", "templatse", "remplates",
Copy link
Contributor Author

@matejvasek matejvasek Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo-detect-hint works out-of-the box. So I deleted it.

@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland @matzew

@matejvasek matejvasek removed the request for review from maximilien July 9, 2024 09:39
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.69%. Comparing base (03a2e24) to head (3650192).

Files Patch % Lines
schema/generator/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2420      +/-   ##
==========================================
+ Coverage   61.22%   66.69%   +5.47%     
==========================================
  Files         130      130              
  Lines       15305    11908    -3397     
==========================================
- Hits         9370     7942    -1428     
+ Misses       5014     3009    -2005     
- Partials      921      957      +36     
Flag Coverage Δ
e2e-test 36.78% <100.00%> (+0.01%) ⬆️
e2e-test-oncluster 33.35% <100.00%> (-0.03%) ⬇️
e2e-test-oncluster-runtime 29.47% <100.00%> (?)
e2e-test-runtime-go 25.12% <100.00%> (?)
e2e-test-runtime-node 26.10% <100.00%> (?)
e2e-test-runtime-python 26.10% <100.00%> (?)
e2e-test-runtime-quarkus 26.20% <100.00%> (?)
e2e-test-runtime-rust 25.22% <100.00%> (?)
e2e-test-runtime-springboot 25.28% <100.00%> (?)
e2e-test-runtime-typescript 26.19% <100.00%> (?)
integration-tests 52.75% <40.00%> (+2.32%) ⬆️
unit-tests 50.91% <40.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Show resolved Hide resolved
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link

knative-prow bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a2a97db into knative:main Jul 9, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants