-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linter issues #2420
Fix linter issues #2420
Conversation
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@@ -37,8 +37,7 @@ DESCRIPTION | |||
the version of func, the version of the function spec, the default builder, | |||
available runtimes, and available templates. | |||
`, | |||
SuggestFor: []string{"env", "environemtn", "enviroment", "enviornment", "enviroment"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typo-detect-hint works out-of-the box. So I deleted it.
@@ -56,11 +56,6 @@ EXAMPLES | |||
o Return Go templates in a specific repository | |||
$ {{rootCmdUse}} templates go --repository=https://github.com/boson-project/templates | |||
`, | |||
SuggestFor: []string{"template", "templtaes", "templatse", "remplates", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typo-detect-hint works out-of-the box. So I deleted it.
PTAL @gauron99 @lkingland @matzew |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
==========================================
+ Coverage 61.22% 66.69% +5.47%
==========================================
Files 130 130
Lines 15305 11908 -3397
==========================================
- Hits 9370 7942 -1428
+ Misses 5014 3009 -2005
- Partials 921 957 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
SuggestFor
in cobra commands since the auto-suggest functionality works just all right.