Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CA bundle #2415

Merged
merged 3 commits into from
Jul 9, 2024
Merged

chore: update CA bundle #2415

merged 3 commits into from
Jul 9, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 8, 2024

  • Updated CA bundle
  • Added EoLs at EoFs
  • Removed trailing whitespaces

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@knative-prow knative-prow bot requested review from dsimansk and vyasgun July 8, 2024 15:48
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 8, 2024
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @matzew @lkingland

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.64%. Comparing base (98dac41) to head (ad54f6e).

❗ There is a different number of reports uploaded between BASE (98dac41) and HEAD (ad54f6e). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (98dac41) HEAD (ad54f6e)
unit-tests-macos-latest 1 0
unit-tests-ubuntu-latest 1 0
e2e-test 1 0
integration-tests 1 0
unit-tests-windows-latest 1 0
e2e-test-oncluster 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2415       +/-   ##
===========================================
- Coverage   61.22%   50.64%   -10.58%     
===========================================
  Files         130      128        -2     
  Lines       15305    11903     -3402     
===========================================
- Hits         9370     6028     -3342     
- Misses       5014     5173      +159     
+ Partials      921      702      -219     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

Why linter started complaining on this PR?

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

PTAL @matzew @gauron99

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link

knative-prow bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f8c54a5 into knative:main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants