Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed tkn tasks in func binary #2396

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jun 26, 2024

Changes

  • Embedded Tekton tasks in the func binary. This removed dependency of files hosted in Github, making func more viable for air-gaped envs. For now I embedded them as plain string, in future I would like to change them into Go struct literals.
  • Since the tasks are no longer present as yaml files in GH I added new hidden sub-command func tkn-tasks that lists these tasks. This is good for information purposes or in cases when the task must be installed in cluster for e.g. OCP Web Console build.

/kind enhancement

feat: embedded Tekton task definitions in the binary

Copy link

knative-prow bot commented Jun 26, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Jun 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@knative-prow knative-prow bot requested review from dsimansk and nainaz June 26, 2024 01:38
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 93.83886% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.74%. Comparing base (64d73de) to head (b0a08ef).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/pipelines/tekton/tasks.go 97.04% 5 Missing ⚠️
cmd/tkn_tasks.go 71.42% 3 Missing and 1 partial ⚠️
docs/generator/main.go 0.00% 2 Missing ⚠️
pkg/pipelines/tekton/templates.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2396      +/-   ##
==========================================
+ Coverage   60.17%   66.74%   +6.56%     
==========================================
  Files         128      130       +2     
  Lines       14898    11911    -2987     
==========================================
- Hits         8965     7950    -1015     
+ Misses       5012     3005    -2007     
- Partials      921      956      +35     
Flag Coverage Δ
e2e-test 36.75% <5.26%> (-1.24%) ⬇️
e2e-test-oncluster 33.41% <86.60%> (+2.22%) ⬆️
e2e-test-oncluster-runtime 29.44% <86.60%> (?)
e2e-test-runtime-go 25.18% <5.26%> (?)
e2e-test-runtime-node 26.14% <5.26%> (?)
e2e-test-runtime-python 26.14% <5.26%> (?)
e2e-test-runtime-quarkus 26.24% <5.26%> (?)
e2e-test-runtime-rust 25.26% <5.26%> (?)
e2e-test-runtime-springboot 25.32% <5.26%> (?)
e2e-test-runtime-typescript 26.23% <5.26%> (?)
integration-tests 52.79% <93.83%> (+3.97%) ⬆️
unit-tests 50.95% <92.41%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Embed Tekton tasks for direct on cluster build.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Embed Tekton tasks for PaC build.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
@matejvasek matejvasek requested review from matzew, jrangelramos, gauron99 and lkingland and removed request for dsimansk and nainaz June 26, 2024 04:08
@matejvasek
Copy link
Contributor Author

PTAL @matzew @lkingland @gauron99

@matejvasek matejvasek marked this pull request as ready for review June 26, 2024 04:12
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2024
@knative-prow knative-prow bot requested review from dsimansk and nainaz June 26, 2024 04:12
This new command prints tektons tasks in form of multi-document yaml,
these tekton tasks may requird to be installed for some advanced
functionality.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

PTAL @gauron99

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Apart from the large embedded yaml, it's a nice cleanup as well.

/hold for anything else from David or David

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link

knative-prow bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland lkingland added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@matejvasek
Copy link
Contributor Author

Looks good to me. Apart from the large embedded yaml, it's a nice cleanup as well.

@lkingland I plan to translate these strings to Go struct literal for type-safety in future.

@matejvasek
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2024
@knative-prow knative-prow bot merged commit 3e8dc4d into knative:main Jun 26, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants