-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: embed tkn tasks in func binary #2396
Conversation
@matejvasek: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
+ Coverage 60.17% 66.74% +6.56%
==========================================
Files 128 130 +2
Lines 14898 11911 -2987
==========================================
- Hits 8965 7950 -1015
+ Misses 5012 3005 -2007
- Partials 921 956 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Embed Tekton tasks for direct on cluster build. Signed-off-by: Matej Vašek <mvasek@redhat.com>
Embed Tekton tasks for PaC build. Signed-off-by: Matej Vašek <mvasek@redhat.com>
PTAL @matzew @lkingland @gauron99 |
This new command prints tektons tasks in form of multi-document yaml, these tekton tasks may requird to be installed for some advanced functionality. Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
PTAL @gauron99 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Apart from the large embedded yaml, it's a nice cleanup as well.
/hold for anything else from David or David
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lkingland I plan to translate these strings to Go struct literal for type-safety in future. |
/unhold |
Changes
func
binary. This removed dependency of files hosted in Github, making func more viable for air-gaped envs. For now I embedded them as plain string, in future I would like to change them into Go struct literals.func tkn-tasks
that lists these tasks. This is good for information purposes or in cases when the task must be installed in cluster for e.g. OCP Web Console build./kind enhancement