Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codegen #2387

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix codegen #2387

merged 1 commit into from
Jun 20, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2024
Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested review from gauron99 and removed request for rhuss June 20, 2024 15:40
@matejvasek
Copy link
Contributor Author

PTAL @jrangelramos @gauron99

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (40eb0eb) to head (fc35eb3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
+ Coverage   60.18%   65.66%   +5.47%     
==========================================
  Files         128      128              
  Lines       14898    11537    -3361     
==========================================
- Hits         8967     7576    -1391     
+ Misses       5011     3003    -2008     
- Partials      920      958      +38     
Flag Coverage Δ
e2e-test 37.98% <ø> (ø)
e2e-test-oncluster ?
e2e-test-oncluster-runtime 27.11% <ø> (?)
e2e-test-runtime-go 26.03% <ø> (?)
e2e-test-runtime-node 26.99% <ø> (?)
e2e-test-runtime-python 26.99% <ø> (?)
e2e-test-runtime-quarkus 27.09% <ø> (?)
e2e-test-runtime-rust 26.08% <ø> (?)
e2e-test-runtime-springboot 26.13% <ø> (?)
e2e-test-runtime-typescript 27.08% <ø> (?)
integration-tests 51.30% <ø> (+2.48%) ⬆️
unit-tests 49.29% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
Copy link

knative-prow bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6f19506 into knative:main Jun 20, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants