Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed deprecated types #2378

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

No description provided.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@knative-prow knative-prow bot requested review from nainaz and vyasgun June 19, 2024 19:59
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 19, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for nainaz and vyasgun June 19, 2024 20:01
@matejvasek
Copy link
Contributor Author

@lkingland @gauron99 PTAL

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (c1c7fa5) to head (ea7f01c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2378      +/-   ##
==========================================
+ Coverage   60.18%   65.70%   +5.52%     
==========================================
  Files         128      128              
  Lines       14895    11534    -3361     
==========================================
- Hits         8964     7578    -1386     
+ Misses       5010     2999    -2011     
- Partials      921      957      +36     
Flag Coverage Δ
e2e-test 37.99% <100.00%> (ø)
e2e-test-oncluster 31.22% <100.00%> (ø)
e2e-test-oncluster-runtime 27.11% <0.00%> (?)
e2e-test-runtime-go 26.03% <100.00%> (?)
e2e-test-runtime-node 27.00% <100.00%> (?)
e2e-test-runtime-python 27.00% <100.00%> (?)
e2e-test-runtime-quarkus 27.10% <100.00%> (?)
e2e-test-runtime-rust 26.09% <100.00%> (?)
e2e-test-runtime-springboot 26.14% <100.00%> (?)
e2e-test-runtime-typescript 27.09% <100.00%> (?)
integration-tests 51.28% <0.00%> (+2.43%) ⬆️
unit-tests 49.28% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
Copy link

knative-prow bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f249714 into knative:main Jun 20, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants