-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected error msg #2372
corrected error msg #2372
Conversation
Signed-off-by: swastik959 <Sswastik959@gmail.com>
Hi @swastik959. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
==========================================
+ Coverage 60.20% 65.68% +5.48%
==========================================
Files 128 128
Lines 14895 11537 -3358
==========================================
- Hits 8967 7578 -1389
+ Misses 5008 3002 -2006
- Partials 920 957 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@swastik959 you need to fix that linter error. |
@matejvasek should I remove the fmt.print for all the conditions ? |
@swastik959 the |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, swastik959 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Changes
/kind bug
Fixes #2257
Release Note
Docs