-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a --registry-insecure flag #2234
Conversation
dprotaso
commented
Mar 16, 2024
- fix env var casing otherwise flags with hyphens will continue to have hyphens
- Introduce an --registry-insecure flag
/hold Deploy is still broken. Tthough I'm noticing 'insecure' in oci.Pusher code is being confused with |
/hold cancel |
All good now - anon is still disabled by default (like it was before). Insecure flag changes the registry scheme |
@@ -58,6 +58,7 @@ Learn more about Knative at: https://knative.dev`, cfg.Name), | |||
// a version prefixed by "FUNC_" | |||
viper.AutomaticEnv() // read in environment variables for FUNC_<flag> | |||
viper.SetEnvPrefix("func") // ensure that all have the prefix | |||
viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! I am surprised this isn't the default behavior
@@ -170,6 +171,7 @@ func bindEnv(flags ...string) bindFunc { | |||
} | |||
viper.AutomaticEnv() // read in environment variables for FUNC_<flag> | |||
viper.SetEnvPrefix("func") // ensure that all have the prefix | |||
viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this duplicate directive is another reason we have a flag refactor/cleanup in the works
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>