-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update setup E2E to match latest Knative release #2189
chore: Update setup E2E to match latest Knative release #2189
Conversation
@dsimansk: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
local contour_version=v1.10.0 | ||
local knative_serving_version=v1.13.0 | ||
local knative_eventing_version=v1.13.0 | ||
local contour_version=v1.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's any benefit to test with Contour as networking-layer for Serving. I'd switch to Kourier if possible. In a follow-up PR.
|
||
# Kubernetes Version node image per Kind releases (full hash is suggested): | ||
# https://github.com/kubernetes-sigs/kind/releases | ||
local kind_node_version=v1.27.1@sha256:b7d12ed662b873bd8510879c1846e87c7e676a79fefc93e17b2a52989d3ff42b | ||
local kind_node_version=v1.29.2@sha256:51a1434a5397193442f0be2a297b488b6c919ce8a3931be0ce822606ea5ca245 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it's locking kind on certain kube version. But we lock kind
binary on certain release version anyway. I wonder if their default isn't enough. At least for current release it matches 1.29.2.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/cc @matejvasek
/wip
Let's see if it works with current dependencies, or we need to bump those first.
Fixes #
Release Note