Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding local field to function for handling transient spec (Local.Remote) #2121

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

vyasgun
Copy link
Contributor

@vyasgun vyasgun commented Jan 18, 2024

Added a Local field to represent the local spec (such as Remote)

Changes

  • 🎁 Added a new field Local.Remote to the function spec
  • 🎁 Modified func.write to write it only to .func/local.yaml so it is not persisted across clones but only locally
  • 🎁 Added unit tests to ensure the expected behaviour

/kind enhancement

Fixes #

Release Note


Docs


@knative-prow knative-prow bot added kind/enhancement size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2024
@knative-prow knative-prow bot requested review from gauron99 and rhuss January 18, 2024 05:23
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (a4e4885) 61.68% compared to head (824941c) 65.14%.
Report is 89 commits behind head on main.

Files Patch % Lines
pkg/functions/function.go 51.72% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
+ Coverage   61.68%   65.14%   +3.46%     
==========================================
  Files         106      108       +2     
  Lines       13693    13919     +226     
==========================================
+ Hits         8446     9068     +622     
+ Misses       4400     3952     -448     
- Partials      847      899      +52     
Flag Coverage Δ
e2e-test 37.37% <38.70%> (+2.19%) ⬆️
e2e-test-oncluster 30.58% <51.61%> (+0.14%) ⬆️
e2e-test-oncluster-runtime 26.82% <25.80%> (?)
e2e-test-runtime-go 25.57% <38.70%> (?)
e2e-test-runtime-node 26.57% <38.70%> (?)
e2e-test-runtime-python 26.57% <38.70%> (?)
e2e-test-runtime-quarkus 26.68% <38.70%> (?)
e2e-test-runtime-rust 25.57% <38.70%> (?)
e2e-test-runtime-springboot 25.71% <38.70%> (?)
e2e-test-runtime-typescript 26.68% <38.70%> (?)
integration-tests 51.85% <32.25%> (+2.52%) ⬆️
unit-tests-macos-latest 48.85% <54.83%> (?)
unit-tests-ubuntu-latest 49.59% <54.83%> (?)
unit-tests-windows-latest 48.87% <54.83%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek requested review from lkingland and removed request for rhuss January 18, 2024 14:09
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good. Thanks for the contribution @vyasgun !

Comment on lines +29 to +30
// Local represents the transient runtime metadata which
// is only relevant to the local copy of the function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good explanation

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
Copy link

knative-prow bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e6c53eb into knative:main Jan 19, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants