Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove create cli subcommand #209

Merged
merged 1 commit into from
Nov 6, 2020
Merged

feat!: remove create cli subcommand #209

merged 1 commit into from
Nov 6, 2020

Conversation

lkingland
Copy link
Member

Removes the faas create subcommand, renaming init to create. #180

@lkingland lkingland requested a review from a team November 5, 2020 15:33
zroubalik
zroubalik reviewed Nov 5, 2020
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but docs should be changed as well.

@lance lance changed the title Remove create cli subcommand feat!: remove create cli subcommand Nov 5, 2020
@lance
Copy link
Member

lance commented Nov 5, 2020

@lkingland any chance you can get the doc changes in before tomorrow's build?

@lkingland
Copy link
Member Author

Unless I am missing some, the relatively small amount of docs referencing the init subcommand by name have now also been updated.

@lkingland lkingland requested a review from a team November 6, 2020 01:53
lkingland added a commit to lkingland/func that referenced this pull request Nov 6, 2020
@lkingland
feat!: remove create cli subcommand (knative#209)
807ab5e
zroubalik
zroubalik approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkingland lkingland merged commit 57e1236 into knative:main Nov 6, 2020
@zroubalik
Copy link
Contributor

@lkingland btw there are some related docs to be change as well in here: https://github.com/boson-project/functions

@lkingland lkingland deleted the remove-create-cli-subcommand branch November 6, 2020 12:11
@lance lance mentioned this pull request Nov 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkingland @lance @zroubalik