Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using $CONTAINER_ENGINE variable instead of hard-coded docker #2066

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 2, 2023

Changes

  • Adding podman as command, instead of docker (like openshift/release repo does it)

/kind

Fixes #

Release Note


Docs


…epo does it)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Copy link

knative-prow bot commented Nov 2, 2023

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Adding podman as command, instead of docker (like openshift/release repo does it)

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad38c17) 62.56% compared to head (b4fdb44) 64.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2066      +/-   ##
==========================================
+ Coverage   62.56%   64.60%   +2.04%     
==========================================
  Files         107      107              
  Lines       13705    13705              
==========================================
+ Hits         8574     8854     +280     
+ Misses       4303     3971     -332     
- Partials      828      880      +52     
Flag Coverage Δ
e2e-test 36.44% <ø> (-0.03%) ⬇️
e2e-test-oncluster 30.49% <ø> (?)
e2e-test-oncluster-runtime 26.95% <ø> (?)
e2e-test-runtime-go 25.58% <ø> (?)
e2e-test-runtime-node 26.59% <ø> (?)
e2e-test-runtime-python 26.59% <ø> (?)
e2e-test-runtime-quarkus 26.70% <ø> (?)
e2e-test-runtime-rust 25.58% <ø> (?)
e2e-test-runtime-springboot 25.72% <ø> (?)
e2e-test-runtime-typescript 26.70% <ø> (?)
integration-tests 51.90% <ø> (+2.04%) ⬆️
unit-tests-macos-latest 48.74% <ø> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.50% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
Copy link

knative-prow bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@knative-prow knative-prow bot merged commit d258a19 into knative:main Nov 2, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants